Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48144 )
Change subject: mb/kontron/mal10: Remove unnecessary includes ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/include/carrier/gpio.h:
https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... PS9, Line 6: #include <gpio.h> uhm... that's definitely wrong lol. "soc/gpio.h" should be used here. suggestion: rename the commit to "Clean up includes" and just do fix that. no new change needed :)
https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/48144/9/src/mainboard/kontron/mal10... PS9, Line 6: #include <gpio.h> not needed here