build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31490 )
Change subject: soc/amd/common: Refactor S3 helpers ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/31490/4/src/soc/amd/common/block/include/amd... File src/soc/amd/common/block/include/amdblocks/s3_resume.h:
https://review.coreboot.org/#/c/31490/4/src/soc/amd/common/block/include/amd... PS4, Line 22: AGESA_STATUS OemInitResume(S3_DATA_BLOCK *dataBlock); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/31490/4/src/soc/amd/common/block/s3/s3_resum... File src/soc/amd/common/block/s3/s3_resume.c:
https://review.coreboot.org/#/c/31490/4/src/soc/amd/common/block/s3/s3_resum... PS4, Line 80: dataBlock->VolatileStorage, (size_t)dataBlock->VolatileStorageSize); line over 80 characters