Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40472 )
Change subject: mb/google/volteer: implement mainboard_get_dram_part_num()
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40472/5/src/mainboard/google/voltee...
File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/40472/5/src/mainboard/google/voltee...
PS5, Line 34: MODULE_PART_NUM_MAX_LEN
Just use DIMM_INFO_PART_NUMBER_SIZE?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40472
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a20691f601cb513ee0936c8d141233c3d06db3d
Gerrit-Change-Number: 40472
Gerrit-PatchSet: 5
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 17 Apr 2020 17:23:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment