Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35297 )
Change subject: soc/amd/picasso: Add basic MTRR settings to hybrid romstage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35297/1/src/soc/amd/picasso/romstag...
File src/soc/amd/picasso/romstage.c:
https://review.coreboot.org/c/coreboot/+/35297/1/src/soc/amd/picasso/romstag...
PS1, Line 67: 1
nitpick ... but errors are normally negative values.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73222097a6a859827c4f91851ab55300cb0d9dcc
Gerrit-Change-Number: 35297
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Oct 2019 23:00:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment