Attention is currently required from: Felix Singer, Maxim Polyakov, Angel Pons, Christoph Pomaska.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7
......................................................................
Patch Set 17:
(1 comment)
File src/mainboard/gigabyte/ga-z170x-gaming7/romstage.c:
https://review.coreboot.org/c/coreboot/+/38920/comment/7f4d2962_ec86b3ad
PS17, Line 7: static void mainboard_fill_rcomp_res_data(void *rcomp_ptr)
: {
: const u16 RcompResistor[3] = { 121, 75, 100 };
: memcpy(rcomp_ptr, RcompResistor, sizeof(RcompResistor));
: }
:
: static void mainboard_fill_rcomp_strength_data(void *rcomp_strength_ptr)
: {
: static const u16 RcompTarget[5] = { 60, 26, 20, 20, 26 };
: memcpy(rcomp_strength_ptr, RcompTarget, sizeof(RcompTarget));
: }
See if any of these configurations work: […]
Anything wrong with the current numbers (I suggested them based on Intel docs).
Also, why guess?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38920
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c69bddd22cbd8f797dbb57370a4d8e5afa63bc
Gerrit-Change-Number: 38920
Gerrit-PatchSet: 17
Gerrit-Owner: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Christoph Pomaska
github@slrie.de
Gerrit-Comment-Date: Thu, 02 Mar 2023 11:34:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment