[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/gpio: Clear interrupt and wake status when configuring...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... 
File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... 
PS4, Line 206: GPIO_WAKE_STATUS
> I think we'd be able to log (eventlog) things w/ b/159947207 once that work is done, but it doesn't  […]

I will have to dig into the kernel driver to see how it handles the WAKE_STATUS. But I agree that in general the kernel might want to send pm_wakeup notification depending upon the WAKE_STATUS bits.