build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32511 )
Change subject: WIP: google/kukui: Elaborate panel support for Kukui family boards.
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32511/4/src/mainboard/google/kukui/display.c
File src/mainboard/google/kukui/display.c:
https://review.coreboot.org/#/c/32511/4/src/mainboard/google/kukui/display.c...
PS4, Line 116: return ERR;
return of an errno should typically be negative (ie: return -ERR)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32511
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19213aee1ac0f69f42e73be9e5ab72394f412a01
Gerrit-Change-Number: 32511
Gerrit-PatchSet: 4
Gerrit-Owner: Kaka Ni
nigang@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kaka Ni
nigang@huaqin.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Apr 2019 13:34:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment