[coreboot-gerrit] Change in coreboot[master]: soc/skl/vr_config: Add VR config for SKL-S/H/U/Y

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35167 )

Change subject: soc/skl/vr_config: Add VR config for SKL-S/H/U/Y
......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35167/3/src/soc/intel/skylake/vr_co... 
File src/soc/intel/skylake/vr_config.c:

https://review.coreboot.org/c/coreboot/+/35167/3/src/soc/intel/skylake/vr_co... 
PS3, Line 148: uint16_t icc_max[NUM_VR_DOMAINS] = {
             : 			VR_CFG_AMP(11.1),
             : 			VR_CFG_AMP(40),
             : 			VR_CFG_AMP(48),
             : 			VR_CFG_AMP(48),
             : 		};
> Hmm, excuse me, but where are the Iccmax for the VR_RING domain? I see in the device tree for some b […]

The macro VR_CFG_ALL_DOMAINS_ICC takes this into account