Attention is currently required from: Guangjie Song, Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86343?usp=email )
Change subject: soc/mediatek/mt8196: Remove tvdpll3 disable/enable
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86343/comment/65ad251a_a7fca481?usp... :
PS1, Line 9: The enable operation cause tvdpll3 cannot be disabled during suspend,
: so we remove it.
: tvdpll3 can be enabled/disabled according to its downstream clock
: demand automatically.
yes […]
1. Add `by hardware` after `automatically` to make that clear
2. Do not start a new line between sentences, unless you want a new paragraph.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86343?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib9c72a1602c1f76dc94cca5c4a61a542a853560b
Gerrit-Change-Number: 86343
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 10 Feb 2025 16:01:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com