EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40487 )
Change subject: mb/google/deltaur: Correct H1 I2C gpio pin setting
......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40487/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40487/1//COMMIT_MSG@9
PS1, Line 9:
Only one space.
Done
https://review.coreboot.org/c/coreboot/+/40487/1//COMMIT_MSG@9
PS1, Line 9: connect
connects?
Done
https://review.coreboot.org/c/coreboot/+/40487/1//COMMIT_MSG@9
PS1, Line 9: using
uses
Done
https://review.coreboot.org/c/coreboot/+/40487/1//COMMIT_MSG@11
PS1, Line 11: BUG=b:150165131
Sorry Paul, sometimes I forget that the context in my head is already there 😊 […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40487
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43c18baea66b927d51689579a40a53f72b94ef36
Gerrit-Change-Number: 40487
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 18 Apr 2020 05:07:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment