[coreboot-gerrit] Change in ...coreboot[master]: WIP: mediaek/mt8183: add panel driver for kukui p2

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32097 )

Change subject: WIP: mediaek/mt8183: add panel driver for kukui p2
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/32097/7/src/mainboard/google/kukui/mainboard... 
File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/#/c/32097/7/src/mainboard/google/kukui/mainboard... 
PS7, Line 66: /* board from p2 */
can you clarify which are needed due to ssd2858?

I think we should refactor this function as

static void configure_display(int has_ssd2858)
 {
   ...
 }

instead of judging by board id.

https://review.coreboot.org/#/c/32097/7/src/mainboard/google/kukui/mainboard... 
PS7, Line 182: else
we probably won't use ssd2858 in future, so the logic here should be

int has_ssd2858 = board_id() == 2;

if (has_ssd2858) {
 } else {
 }