Deepika Punyamurtula has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46676 )
Change subject: UPSTREAM: mb/google/volteer/variants/delbin: Update DPTF parameters for delbin
......................................................................
Patch Set 10:
(1 comment)
Thank you Frank for the update. Please help address one more about PL4 value.
https://review.coreboot.org/c/coreboot/+/46676/10/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46676/10/src/mainboard/google/volte...
PS10, Line 8: .tdp_pl2_override = 51,
Can you also please add .tdp_pl4 = 105, ?
If pl4 = 105 in your case
I have seen that without this it picks up a value of 121 for PL4.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46676
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69aa6046fdc90a2cf59ea3a13fdb15c8bc0d29a2
Gerrit-Change-Number: 46676
Gerrit-PatchSet: 10
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Deepika Punyamurtula
deepika.punyamurtula@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 29 Oct 2020 16:39:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
