Attention is currently required from: Arthur Heymans, Tristan Corrick, Angel Pons, Alexander Couzens, Patrick Rudolph.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58604 )
Change subject: cpu/intel/haswell: Remove the fake lapic
......................................................................
Patch Set 1:
(2 comments)
File src/cpu/intel/haswell/acpi.c:
https://review.coreboot.org/c/coreboot/+/58604/comment/4ec3a58a_dccf8eb3
PS1, Line 175: s0ix_enable
On platforms with separate CPU/northbridge/southbridge devicetree chips, `config_of_soc()` returns t […]
Thanks for the explanation. I haven't worked on any non-SoC boards :)
File src/cpu/intel/haswell/haswell_init.c:
https://review.coreboot.org/c/coreboot/+/58604/comment/cf151e76_de0909be
PS1, Line 182: struct cpu_info *info = cpu_info();
: if (!info)
: return;
Can `cpu_info()` ever return a null pointer? If so, why does acpi. […]
It should never return a NULL pointer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69f9c1fe71a773e1fba0942d8a785b6ad26dd9a0
Gerrit-Change-Number: 58604
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 11 Nov 2021 15:52:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment