Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43684 )
Change subject: cpu/x86/smm: Introduce SMM module loader version 2
......................................................................
Patch Set 4:
(1 comment)
Angel,
I incorporated your changes from the other patch. I've added one more change in mp_init.c. There are 2 SMM regions:
1. Default Region at 30000h. During this relocation phase only so many CPUs can relocate at the same time otherwise the state save will corrupt the entry code. Therefore, you will notice I added code to handle this case which means CPUs will relocate one at a time. This will add a slight delay to the boot time (hopefully its negligible). Unfortunately there is nothing we can do because of the SMRAM HW limitations.
https://review.coreboot.org/c/coreboot/+/43684/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43684/3//COMMIT_MSG@7
PS3, Line 7: cpu/x86/smm: SMM module loader version 2
Please make it a statement by adding a verb (in imperative mood).
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00a23a5f2a46110536c344254868390dbb71854c
Gerrit-Change-Number: 43684
Gerrit-PatchSet: 4
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Eugene Myers
cedarhouse1@comcast.net
Gerrit-Reviewer: Eugene Myers
cedarhouse@comcast.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 21:13:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment