Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )
Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede...
PS6, Line 298: 0x0D
Not quite sure if the address lines are indexed from 0 to 0xD (i.e. 14 lines) or from 1 to 0xD (i.e. […]
Updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19e4a4107c5bc9d96f718d654df50e2705b98c03
Gerrit-Change-Number: 41173
Gerrit-PatchSet: 7
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 06:19:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment