Marc Jones has uploaded this change for review. ( https://review.coreboot.org/28256
Change subject: x86/acpi: Update MADT table version ......................................................................
x86/acpi: Update MADT table version
Update the MADT table version to sync with the FADT table version. All current coreboot FADT tables are set to ACPI_FADT_REV_ACPI_3_0 and the MADT should be set to match.
This error was found by running FWTS: FAILED [MEDIUM] SPECMADTFADTRevisions: Test 2, MADT revision is not in sync with the FADT revision; MADT 1 expects FADT 3.0 but found 4.0 instead.
The test report is a little confusing due to the revision index not matching the ACPI spec versions.
BUG=b:112476331 TEST-Run FWTS
Change-Id: If5ef53794ff80dd21f13c247d17c2a0e9f9068f2 Signed-off-by: Marc Jones marcj303@gmail.com --- M src/arch/x86/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/28256/1
diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index 8d7579d..69e1e2f 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -218,7 +218,7 @@ memcpy(header->asl_compiler_id, ASLC, 4);
header->length = sizeof(acpi_madt_t); - header->revision = 1; /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0: 3 */ + header->revision = 2; /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0: 3 */
madt->lapic_addr = LOCAL_APIC_ADDR; madt->flags = 0x1; /* PCAT_COMPAT */