Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46506 )
Change subject: drivers/uart: Fix control flow DEADCODE issue ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46506/2/src/drivers/uart/acpi/acpi.... File src/drivers/uart/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/46506/2/src/drivers/uart/acpi/acpi.... PS2, Line 77: acpi_device_write_gpio(&config->irq_gpio); : irq_gpio_index++; Reading back over what this is doing, even though this is the first pin added, it's probably best to do what the other pins are doing, e.g.: ``` irq_gpio_index = uart_acpi_write_gpio(&config->irq_gpio, &curr_index); ``` since curr_index is used as state between calls to uart_acpi_write_gpio