Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45673 )
Change subject: mb/google/volteer/var/terrador: Enable audio SMBIOS OEM string ......................................................................
Patch Set 1: Code-Review+1
Patch Set 1:
Patch Set 1:
Hi,
One question: In base volteer device tree, we had all Codec entries.. so we needed this CONFIG_ selection.
In particular variants, like: variants/terrador/overridetree.cb: only relevant Codec ACPI entries are there. So, we may not need to add this CONFIG, right?
The probe statement for audio codec is in variants/volteer/overridetree.cb but not in variants/baseboard/devicetree.cb.
Without adding this, can't we get DMI OEM string by setting the particular CBI value?
Accroading to cb:44782, it must to have probe statement to get the DMI OEM string.
got it, thanks Kevin!