build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45192 )
Change subject: soc/intel/alderlake/romstage: Do initial SoC commit till romstage ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... PS1, Line 29: dev = pcidev_path_on_root(SA_DEVFN_IGD); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... PS1, Line 29: dev = pcidev_path_on_root(SA_DEVFN_IGD); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... PS1, Line 30: m_cfg->InternalGfx = is_dev_enabled(dev); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... PS1, Line 30: m_cfg->InternalGfx = is_dev_enabled(dev); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... PS1, Line 31: m_cfg->IgdDvmt50PreAlloc = m_cfg->InternalGfx ? 0xFE : 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... PS1, Line 31: m_cfg->IgdDvmt50PreAlloc = m_cfg->InternalGfx ? 0xFE : 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... PS1, Line 67: DEBUG_INTERFACE_UART_8250IO : DEBUG_INTERFACE_LPSS_SERIAL_IO; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... PS1, Line 67: DEBUG_INTERFACE_UART_8250IO : DEBUG_INTERFACE_LPSS_SERIAL_IO; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45192/1/src/soc/intel/alderlake/rom... PS1, Line 155: /* Skip CPU side PCIe enablement in FSP if device is disabled in devicetree */ code indent should use tabs where possible