[coreboot-gerrit] Change in coreboot[master]: mainboard/google/volteer: Disable S0i3.4 if cr50 firmware is too old

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44359 )

Change subject: mainboard/google/volteer: Disable S0i3.4 if cr50 firmware is too old
......................................................................

Patch Set 20: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/44359/19//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44359/19//COMMIT_MSG@29 
PS19, Line 29:  But it is entirely possible that
             : we have just been "lucky" that the SoC has not gone into low power
             : mode during the boot process, where most of the cr50 communication
             : happens.
> True, but we do still have cr50 communication when the user logs in, to mount the home directory, wh […]

IIRC, there is a timeout in the kernel driver, so if the AP doesn't receive the IRQ after a certain time, it will go and read from it to check the status.