Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Make stage cache kconfig selection proper ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@244 PS17, Line 244: default !NO_RELOCATABLE_STAGES
This equates STAGE_CACHE with RELOCATABLE_STAGES/RELOCATABLE_RAMSTAGE. […]
If a platform does not support relocatable ramstage, but still wants to use stage cache to stash refcode/S3 data for example, would that be a valid use case?
Right now this is invalid usecase and platform will hang in S3 resume.
https://review.coreboot.org/c/coreboot/+/33116/17/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33116/17/src/arch/x86/Makefile.inc@... PS17, Line 378: CONFIG_STAGE_CACHE
It just feels a bit twisted that ramstage being a rmodule is dependent on availability of stage cach […]
we should make this !NO_RELOCATABLE_RAMSTAGE ?