Attention is currently required from: Ana Carolina Cabral, Felix Held.
Martin Roth has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/85493?usp=email )
Change subject: mb/amd/birman_plus: Kconfig ......................................................................
Patch Set 8:
(3 comments)
File src/mainboard/amd/birman_plus/Kconfig:
https://review.coreboot.org/c/coreboot/+/85493/comment/cf1b4bcc_bdc2110b?usp... : PS8, Line 131: Disable WWAN "Disable both WWAN & GbE"?
https://review.coreboot.org/c/coreboot/+/85493/comment/21698062_51d86a8f?usp... : PS8, Line 147: Disable WLAN "Disable WLAN & SD Card"?
File src/mainboard/amd/birman_plus/port_descriptors_glinda.c:
https://review.coreboot.org/c/coreboot/+/85493/comment/eb6aeec8_2915723a?usp... : PS8, Line 87: 14 So this is just ignored if it's set to disabled? I'd think we'd just want to the GBE/SD entries if WWAN & WLAN are enabled.
To me, this configuration is saying in the WLAN entry that we're using 14, and then here we're saying to disable 14.
At the very least maybe add a comment saying that this entry pretty much gets ignored because lane 14 is already allocated above - if that's the case, and I don't know whether it is or not.
Obviously this is the same for GBE & for the other port descriptors file.