Attention is currently required from: Michał Żygowski, Christian Walter.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69708 )
Change subject: security/tpm/tspi/log.c: fix strncpy() usage
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This is still custom coreboot format right?
Yes.
It is up to the parser to respect the format and be aware that the fields do not necessarily have to be NULL-terminated.
I don't think that was the original intent. If it was, the whole field would be used, but the code explicitly doesn't write last byte as if assuming it to be zero to guarantee string termination.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69708
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib24129829bef3764a8ba1e2c0d92bc42c5cfbc8d
Gerrit-Change-Number: 69708
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Fri, 18 Nov 2022 16:18:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment