Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32992 )
Change subject: soc/intel/cannonlake: Add ability to disable Heci1
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32992/15//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/32992/15//COMMIT_MSG@12
PS15, Line 12: TEST=Boot to OS, verify if Heci1 is disabled
What device was this tested on? What FSP version was used to test this?
Sorry about late reply, I was on vacation.
Tested with FSP 1344 on hatch, updated the comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c63316c8b04fb101d34064daac5ba4fdc05a63c
Gerrit-Change-Number: 32992
Gerrit-PatchSet: 16
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Sep 2019 19:09:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment