Attention is currently required from: Nico Huber, Paul Menzel.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/82632?usp=email )
Change subject: sio/nuvoton: Implement a common ramstage ACPI LDN helper ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5: Now that I think about it, in the future I'll want to make the port role swapping automatic if keyboard init fails (which would happen when initializing LDN 5), but the actual switch is in LDN A. There will have to be some data sharing (keyboard code needs to let ACPI code know keyboard init failed) but this current code may be too siloed for this purpose. Suggestions? Split the port role swapping?
File src/superio/nuvoton/common/common.c:
https://review.coreboot.org/c/coreboot/+/82632/comment/110b5e11_11c660c9?usp... : PS5, Line 53: /* TODO: Show proper message for "keep". */
Let's do that right away? How about an array […]
Oh yeah that's how! Thanks for the tip
https://review.coreboot.org/c/coreboot/+/82632/comment/0c8983e7_a4415a34?usp... : PS5, Line 61: KB_WAKEUP_ANYKEY
I'm not convinced this is what everybody wants/expects. In particular the "any […]
Or nvram option?