Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42740 )
Change subject: mb/google/sarien: Enable bayhub 720 on Sarien
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42740/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42740/3//COMMIT_MSG@9
PS3, Line 9: Add PCIe-eMMC bridge bayhub 720 on Sarien.
Why is the mainboard code needed, and can’t be in the common driver? […]
We reference grunt.
https://review.coreboot.org/c/coreboot/+/42740/3/src/mainboard/google/sarien...
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42740/3/src/mainboard/google/sarien...
PS3, Line 401: end
Please consistently use tabs for indentation.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42740
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28f40a420d51f476487655548f386cfbdc2e5329
Gerrit-Change-Number: 42740
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Jul 2020 02:01:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment