Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41771 )
Change subject: tests: Allow emitting junit output for unit tests ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41771/1/tests/Makefile.inc File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41771/1/tests/Makefile.inc@140 PS1, Line 140: $(alltests): export CMOCKA_XML_FILE=$(testobj)/junit-$(subst /,_,$^).xml That's nice. Wasn't aware that we can use $^ (automatic variables in general) in per-target variable definition. Is this actually expanded during the execution of recipe?
https://review.coreboot.org/c/coreboot/+/41771/1/tests/Makefile.inc@144 PS1, Line 144: rm -f $(testobj)/junit-$(subst /,_,$^).xml When checkout on this commit, we may end up with some stale xmls saying that test passed, even though it was not executed (due to failure of some test earlier in the queue). You are changing this behavior in 4/4 - maybe we should change the order of commits?
Anyway, why not to remove all xmls with "make clean-unit-tests" and force "what-jenkins-does" to issue "clean-unit-tests" before "make unit-tests"?