Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42154 )
Change subject: sb/intel/lynxpoint: Use PCI bitwise ops
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42154/13/src/southbridge/intel/lynx...
File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/42154/13/src/southbridge/intel/lynx...
PS13, Line 250: /* FIXME: Are we supposed to update this register with a constant boolean? */
You fixed up the same thing on line 263, so why not treat them the same?
https://review.coreboot.org/c/coreboot/+/42154/13/src/southbridge/intel/lynx...
PS13, Line 619: pci_update_config32
pci_write_config32 since the mask is 0?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42154
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27d6aaa59e12a337f80a6d3387cc9c8ae5949384
Gerrit-Change-Number: 42154
Gerrit-PatchSet: 13
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 17:46:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment