Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: soc/mediatek/mt8183: Use cached calibration result for faster bootup ......................................................................
Patch Set 36:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35164/35/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35164/35/src/soc/mediatek/mt8183/dr... PS35, Line 1011: if (params->source == DRAMC_PARAM_SOURCE_FLASH) { : dramc_dbg("[bypass Gating]\n"); : } else {
if (param->source == DRAMC_PARAM_SOURCE_SDRAM_CONFIG) { […]
Done
https://review.coreboot.org/c/coreboot/+/35164/29/src/soc/mediatek/mt8183/em... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35164/29/src/soc/mediatek/mt8183/em... PS29, Line 365: const struct sdram_params *freq_params
That's not a problem, as long as we don't need complete definition in emi.h. […]
Done