huayang duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32010 )
Change subject: mediatek/mt8183: enable DDR low power feature ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/#/c/32010/1/src/soc/mediatek/mt8183/dramc_pi_bas... File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/#/c/32010/1/src/soc/mediatek/mt8183/dramc_pi_bas... PS1, Line 264: static void DramcDummyReadForTrackingEnable(u8 chn)
lower case to be consistent with other functionns
Done
https://review.coreboot.org/#/c/32010/1/src/soc/mediatek/mt8183/dramc_pi_bas... PS1, Line 284: static void SetCKE2RankIndependent(u8 chn)
lower case to be consistent with other functions
Done
https://review.coreboot.org/#/c/32010/6/src/soc/mediatek/mt8183/dramc_pi_bas... File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/#/c/32010/6/src/soc/mediatek/mt8183/dramc_pi_bas... PS6, Line 328:
extra blank line?
Done
https://review.coreboot.org/#/c/32010/6/src/soc/mediatek/mt8183/dramc_pi_cal... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/#/c/32010/6/src/soc/mediatek/mt8183/dramc_pi_cal... PS6, Line 130:
Will this function be called from any other files?
this function not be called from other files, I have make this function as static. thanks.