Attention is currently required from: Marc Jones, Nico Huber, Jonathan Zhang, Ryback Hung, Johnny Lin, Tim Wawrzynczak, Paul Menzel, Shuming Chu (Shuming).
Wilson Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67264 )
Change subject: device: Clear lane error status
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS2:
Wilson, let's add a code comment accordingly: Lane error status is cleared if PCIEXP_LANE_ERR_STAT_C […]
Done
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/67264/comment/e6096d9e_c5afb403
PS5, Line 551: printk(BIOS_DEBUG, "%s: Clear Lane Error Status.\n", dev_path(dev));
Wilson, let's print the current value while we clear it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67264
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6344223636409d8fc25e365a6375fc81e69f41a5
Gerrit-Change-Number: 67264
Gerrit-PatchSet: 6
Gerrit-Owner: Wilson Chou
wilson.chou%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Ryback Hung
ryback.hung@quantatw.com
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Ryback Hung
ryback.hung@quantatw.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Comment-Date: Wed, 07 Sep 2022 07:05:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wilson Chou
wilson.chou%quantatw.com@gtempaccount.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment