Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38988 )
Change subject: mainboard: Add new board ASUS P8Z77-M ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38988/11/src/mainboard/asus/p8z77-m... File src/mainboard/asus/p8z77-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/38988/11/src/mainboard/asus/p8z77-m... PS11, Line 89: /* This sequence enables early serial */ : SWITCH_TO, NCT6779D_SP1, : PNP_IDX_EN, 0, : PNP_IDX_IO0, CONFIG_TTYS0_BASE >> 8, : PNP_IDX_IO0 + 1, CONFIG_TTYS0_BASE & 0xff, : PNP_IDX_EN, 1,
Angel: You mean CONFIG(BOOTBLOCK_CONSOLE)? But Arthur has a point. […]
Oh, I did that already: CB:43582
I didn't do it to slim down the coreboot.rom, but rather to make serialice work without needing to filter Super I/O configuration cycles. Since `nuvoton_enable_serial` disables the UART LDN when programming the base address, it kills serialice (where the SUT and a VM communicate through a serial port)