Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39130 )
Change subject: vendorcode/intel/fsp: Add Jasper Lake FSP headers for FSP v2052
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39130/6/src/vendorcode/intel/fsp/fs...
File src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspsUpd.h:
https://review.coreboot.org/c/coreboot/+/39130/6/src/vendorcode/intel/fsp/fs...
PS6, Line 653: FSPS_UPD;
The total size of FSPS_UPD does not match with what is released in the version 2052. The UpdTerminator is at offset 0xCCE here whereas it is at offset 0xF3E in v2052. Even the size of FSP_S_CONFIG seems to differ. I am not sure if that is correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb911418a6f8fe573b8d097b519c433e8ea6bd73
Gerrit-Change-Number: 39130
Gerrit-PatchSet: 6
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 28 Feb 2020 06:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment