Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46390 )
Change subject: soc/mediatek: Move auxadc driver from MT8183 to common ......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46390/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46390/26//COMMIT_MSG@9 PS26, Line 9: Move auxadc driver from MT8183 to common, : update boardid.c file to avoid build fail. : : [Description] : 1. AUXADC: auxiliary analogue-to-digital conversion : The auxiliary ADC unit is used to identify the plugged : peripheral and perform temperature/voltage measurement. : : 2. AUXADC will check whether the busy bit or data ready bit is ok : before preparing for samping, or before/after trigggering sampling, : and then decide whether to jump out or continue samping. : In the worst case, time to check a busy bit or data ready bit will be delayed 300ms : (Under normal circumstances, there is almost no delay or occasionally : a few ms delay can be checked ok). : The entire sampling flow, there will be a total of 3 check busy bit or data ready bit procee. The auxadc (auxiliary analogue-to-digital conversion) is a unit to identify the plugged peripherals or measure the temperature or voltages.
The MT8183 auxadc driver can be shared by multiple Mediatek SOCs so we should move it to the common folder.