24 Mar
2024
24 Mar
'24
8:26 p.m.
Attention is currently required from: Matt DeVillier, Nico Huber.
Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors and further options ......................................................................
Patch Set 4:
(1 comment)
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81426/comment/e2bdf4c4_53a905ed : PS1, Line 369: #endif
I guess the original intention was to keep the configuration struct clean […]
A new C file would still require the code to be called from somewhere and thus yield similar "problems" as we were discussing already, wouldn't it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81426?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94
Gerrit-Change-Number: 81426
Gerrit-PatchSet: 4
Gerrit-Owner: Joel Linn jl_coreboot@conductive.de
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Sun, 24 Mar 2024 23:26:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Comment-In-Reply-To: Joel Linn jl_coreboot@conductive.de
Gerrit-MessageType: comment