[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC contr...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30614 )

Change subject: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC controller
......................................................................

Patch Set 3:
> > > > Only remaining option is to use coreboot's ssdt generator.
> > >
> > > Or test _STA method proper.
> >
> > _STA is against the ACPI spec in case of PCI device. i don't
> > understand whats the point of pushing in that line ?
>
> Because I couldn't find anything in ACPI spec telling that. Can
> you point me to the specific paragraph, please?

I thought you read entire gerrit discussion's for this CL.

I have replied the same in Jan 10th that.

src/soc/intel/cannonlake/acpi/scs.asl
Line 30:
. For _HID devices, OSPM evaluates the _STA method. For _ADR devices, OSPM checks with the bus driver for that
device

https://www.uefi.org/sites/default/files/resources/ACPI_6.0.pdf
section 6.3.3