Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )
Change subject: mrc_cache: Update mrc_cache data in romstage ......................................................................
Patch Set 24:
(9 comments)
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... PS22, Line 314: struct
const struct
Done
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... PS22, Line 326: BIOS_INFO
nit: still not BIOS_ERR... […]
Done
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... PS22, Line 337: (
If need_update is set to true above, there is no need to compare the data. […]
Done
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... PS22, Line 422: new_md, : new_data, new_data_size)
nit: I think this might fit on a single line with 96-column limit?
Done
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... PS22, Line 442: BIOS_DEBUG
Here too, errors like these should really all use BIOS_ERR.
Done
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... PS22, Line 593: (void *)
nit: unnecessary cast, cbmem_entry_start() already returns (void *)
Done
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... PS22, Line 594:
nit: bad alignment? (don't use spaces unless you're aligning it to something specific, which I don't […]
Done
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... PS22, Line 602: MRC_WRITE_NV_LATE
As per the latest comment, this will have to be MRC_STASH_TO_CBMEM
Done
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_... PS22, Line 636: MRC_WRITE_NV_LATE
MRC_STASH_TO_CBMEM
Done