Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31517 )
Change subject: googe/kukui: Add mt8183 display usecase
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/31517/5/src/mainboard/google/kukui/mainboard...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31517/5/src/mainboard/google/kukui/mainboard...
PS5, Line 50:
I think there's no good reason to put blank lines in each of the function call here and below. Please remove the blank lines.
https://review.coreboot.org/#/c/31517/5/src/mainboard/google/kukui/mainboard...
PS5, Line 61: printk(BIOS_INFO, "Starting display init.\n");
You've removed this in follow up CLs. What about just remove it now?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b3f04cc2d044789bab4c3f0f03b3a904714158f
Gerrit-Change-Number: 31517
Gerrit-PatchSet: 5
Gerrit-Owner: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Reviewer: Chun-ta Lin
itspeter@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-CC: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: You-Cheng Syu
youcheng@google.com
Gerrit-Comment-Date: Wed, 10 Apr 2019 07:37:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
