[coreboot-gerrit] Change in coreboot[master]: device/oprom: List all supported vesa mode by oprom

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34284 )

Change subject: device/oprom: List all supported vesa mode by oprom
......................................................................

Patch Set 7:
> I get this:
> $ qemu-system-i386 -bios build/coreboot.rom -serial stdio
> [...]
> PCI: 00:02.0 init ...
> CBFS: 'Master Header Locator' located CBFS at [200:40000)
> CBFS: Locating 'pci1234,1111.rom'
> CBFS: 'pci1234,1111.rom' not found.
> Option ROM address for PCI: 00:02.0 = fe060000
> Copying VGA ROM Image from fe060000 to 0xc0000, 0x9600 bytes
> Calling Option ROM...
> ... Option ROM returned.
> VBE: Getting information about VESA mode 5234
> VBE: Function call failed!
>
> Error: In vbe_get_mode_info function
>
> Which seems correct regarding VBE spec. But it dies before it can
> show the list of supported video modes :-(

It guess its different error rather current video mode

AH == 0x01: Function call failed

the list of supported video modes will only appear in case of AH == 3