Ben Gardner (gardner.ben@gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14040
-gerrit
commit 9b251ffa2da05a62cd5da3c73ab5b033789e58a9 Author: Ben Gardner gardner.ben@gmail.com Date: Fri Mar 11 14:50:35 2016 -0600
intel/fsp_baytrail: Don't clear gnvs in acpi_init_gnvs()
That wipes out all previously stored settings and breaks running devices in ACPI mode. This more closely matches what is done in intel/baytrail.
Change-Id: Ie993c9f9e1eceb73d016d2df72770a27abb26ec1 Signed-off-by: Ben Gardner gardner.ben@gmail.com --- src/soc/intel/fsp_baytrail/acpi.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/src/soc/intel/fsp_baytrail/acpi.c b/src/soc/intel/fsp_baytrail/acpi.c index e55709c..0156816 100644 --- a/src/soc/intel/fsp_baytrail/acpi.c +++ b/src/soc/intel/fsp_baytrail/acpi.c @@ -85,9 +85,6 @@ static acpi_cstate_t cstate_map[] = {
void acpi_init_gnvs(global_nvs_t *gnvs) { - /* Clear gnvs area so uninitialized portions are defined */ - memset(gnvs, 0, sizeof(*gnvs)); - /* CPU core count */ gnvs->pcnt = dev_count_cpu();