Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40561 )
Change subject: soc/intel/common: Add downgrade support for CSE Firmware
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40561/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40561/5//COMMIT_MSG@10
PS5, Line 10: compatible
compatibility
Done
https://review.coreboot.org/c/coreboot/+/40561/5//COMMIT_MSG@11
PS5, Line 11: the data compatible issues
such issues
Done
https://review.coreboot.org/c/coreboot/+/40561/5//COMMIT_MSG@13
PS5, Line 13: adowngrade
missing space
Done
https://review.coreboot.org/c/coreboot/+/40561/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/custom_bp.c:
https://review.coreboot.org/c/coreboot/+/40561/5/src/soc/intel/common/block/...
PS5, Line 472: nn
remove one `n`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a3a3036e448e5a743398f6b27e8e62965dbff3c
Gerrit-Change-Number: 40561
Gerrit-PatchSet: 6
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Apr 2020 20:56:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment