Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41797 )
Change subject: mb/google/volteer: move volteer-specific GPIOs to variant gpio.c
......................................................................
Patch Set 3:
Patch Set 1:
Patch Set 1:
don't we also need to add most of the "removed" entries to the rest of the variants so they preserve expected functionality?
Yes. I noted that in comment above, but don't want to start that work until I know the volteer changes are correct and what we want. I think this patchset has an issue, though, will update soon.
re comment from above : "Patch Set 1:
This CL is still missing changes to all variants gpio.c override file to match the changes being made here. To save work, I will add those to this CL once these changes are approved."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f384f539d55a3a8d4a7608336ef22aca3d8c4f
Gerrit-Change-Number: 41797
Gerrit-PatchSet: 3
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 29 May 2020 22:07:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment