Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32931 )
Change subject: soc/amd/common: Update AcpiMmio comments ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32931/1/src/soc/amd/common/block/include/amd... File src/soc/amd/common/block/include/amdblocks/acpimmio.h:
https://review.coreboot.org/#/c/32931/1/src/soc/amd/common/block/include/amd... PS1, Line 24: so the caller should be careful not to : * inadvertently access a non-existent block
It seems risky to rely on callers to do this since most callers might not realize this as the functi […]
I've tried to address that in https://review.coreboot.org/c/coreboot/+/32934, although I should probably remove this comment from that patch.