Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38994 )
Change subject: soc/intel/xeon_sp: Enable LPC generic IO decode range
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38994/2/src/soc/intel/xeon_sp/bootb...
File src/soc/intel/xeon_sp/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38994/2/src/soc/intel/xeon_sp/bootb...
PS2, Line 55: pch_early_iorange_init();
do you plan on adding more stuff into bootblock/pch. […]
No I don't plan to add more stuff, this was referenced from other Intel soc code such as src/soc/intel/skylake/bootblock/bootblock.c, I thought people may add similar functions here later so I added it like a placeholder, but I can change it to only call pch_early_iorange_init(). Will change and verify later after the dependant changes are ready.
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38994
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I675489d3c66dad259e4101a17300176f6c0e8bd8
Gerrit-Change-Number: 38994
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Mar 2020 05:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Gerrit-MessageType: comment