6 Jun
2019
6 Jun
'19
1:42 a.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30822 )
Change subject: sb/intel/i82801gx: Detect if the southbridge supports AHCI ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/30822/11/src/southbridge/intel/i82801gx/sata... File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/#/c/30822/11/src/southbridge/intel/i82801gx/sata... PS11, Line 64: return;
This still bails out too early. It should skip the `ahci_supported` part […]
The print message needs updating, but if the first function on the PCI device cannot be found it makes little sense to try to configure other ones?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30822
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d9f4e63ae8b2862c422938f3103c44e761bcda4
Gerrit-Change-Number: 30822
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Wed, 05 Jun 2019 23:42:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment