Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37667 )
Change subject: libpayload: Read from cbmem console
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37667/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37667/1//COMMIT_MSG@9
PS1, Line 9: To support the new recovery ui (the Groot project)
That is a Chrome OS specific thing so we should replace this with some generic term.
"To support showing cbmem logs on screen" should be good enough.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie324055f5fd8276f1d833fc9d04f60a792dbb9f6
Gerrit-Change-Number: 37667
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-CC: Ting Shen
phoenixshen@chromium.org
Gerrit-Comment-Date: Thu, 12 Dec 2019 07:47:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment