Attention is currently required from: Martin L Roth, Werner Zeh.
Felix Singer has posted comments on this change by Werner Zeh. ( https://review.coreboot.org/c/coreboot/+/85915?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Documentation: Fix wrong link to commit message guidelines ......................................................................
Patch Set 1: Code-Review+1
(7 comments)
Patchset:
PS1: Thank you!
File Documentation/contributing/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/85915/comment/46b456d6_24ce8512?usp... : PS1, Line 445: - Please use asterisks for consistency as it's done for all other places in this document.
https://review.coreboot.org/c/coreboot/+/85915/comment/c5091cb8_196d1c2b?usp... : PS1, Line 455: gerrit Uppercase
```suggestion - A Change-Id: line to let Gerrit track this logical change```
https://review.coreboot.org/c/coreboot/+/85915/comment/d3c57d1c_50f4fe0e?usp... : PS1, Line 456: signed Uppercase
```suggestion - A Signed-off-by: line according to [Signed-off-by policy](#sign-off-procedure)```
https://review.coreboot.org/c/coreboot/+/85915/comment/a6f2a261_c2ff3840?usp... : PS1, Line 459: install the commit-msg hook Since there is no reference, it's a bit confusing how to get this thing. I don't have an easy way to solve this without adding much more text. Should we leave it for now and look for a better way later?
https://review.coreboot.org/c/coreboot/+/85915/comment/abde82f7_7df7590f?usp... : PS1, Line 460: to Typo
```suggestion let the script do it for you. And remember to always use ```
https://review.coreboot.org/c/coreboot/+/85915/comment/a66a8f2f_a416b2e2?usp... : PS1, Line 468: she or he Simplification
```suggestion * If anyone involved in coreboot reads your comment in a year or so, they```