Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )
Change subject: mrc_cache: Update mrc_cache data in romstage ......................................................................
Patch Set 7:
(2 comments)
To get the strago boards building properly, I set CONFIG_MRC_WRITE_NV_LATE=y due to a problem with the CAR overflowing. I am not sure if this is the right call though because I think that it pushes the writing back of the mrc_cache data further back than it was originally.
https://review.coreboot.org/c/coreboot/+/44196/3/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/44196/3/src/drivers/mrc_cache/mrc_c... PS3, Line 327: // we need to compare the md and the data separately
Other comments in this file use C-style comments
Done
https://review.coreboot.org/c/coreboot/+/44196/3/src/drivers/mrc_cache/mrc_c... PS3, Line 419: new_data, new_data_size)) {
Are the printk's dropped here redundant?
Done