Attention is currently required from: Martin Roth, Julius Werner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51551 )
Change subject: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Does this affect the comments on Gerrit? If so, I wouldn't want
to change it. Especially not in the case of UNNECESSARY_ELSE.
We'd be back at manually bikeshedding when the indentation level
gets too far because of nested conditions.
Could we clarify the text that it's more a suggestion, instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51551
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I130598057c1800277a129ae6b927e961d6e26e42
Gerrit-Change-Number: 51551
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 01 Apr 2021 19:10:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment