Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47769 )
Change subject: util/amdfwtool: Fix EFS generation polarity ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47769/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/47769/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1206: amd_romsig->second_gen_efs = 0xfffffffe; i'd add and use defines for the EFS generation values and assign them to the struct field. i'd also keep the assignments in the other generations that get removed here, so that isn't implicitly set